Update the documentation regarding Let's Encrypt #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed at DIG that there was a CLA submitted, so this is covered. @misilot will resend to make sure it gets filed properly, but it can be considered ok for merging purposes 😄 |
|
With Islandora-Devops/isle-dc#228 being merged I suspect that these documentation change can be merged now. @misilot I assume that are no changes needed to your docs and they can go in as is since the Islandora-Devops/isle-dc#228 merge ? |
|
@ysuarez, yes I believe it is good to go. The PR was merged as is without any changes. Thank you! |
With the additions from Islandora-Devops/isle-dc#228 requesting certificates via ACME / Let's Encrypt has changed, and should be easier for users to utilize.
|
No, thank you @misilot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the additions from Islandora-Devops/isle-dc#228 requesting
certificates via ACME / Let's Encrypt has changed, and should be easier
for users to utilize.
Purpose / why
Updated the documentation relating to requesting SSL Certificates through Let's Encrypt and Traefik.
https://islandora.github.io/documentation/installation/docker-custom/#using-lets-encrypt-instead-of-certificate-files
What changes were made?
Updated text to reflect only having to change environment variables in the
.envfile.Verification
If Islandora-Devops/isle-dc#228 gets merged, ACME Certificate generation is controlled by a few simple variables. Also debugging Traefik would be also controlled by a variable.
Interested Parties
@Islandora/documentation
@Islandora/8-x-committers_
Checklist